Fix regression in API controllers with view_cache_dependencies helper #575
+2
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails 8's API controllers now includes the
Caching
module by default (to supportrate_limit
in API controllers), but does not include the Helpers module.This causes the jbuilder
cache
method to raise an exception because the Rails caching module does not add thehelper_method :view_cache_dependencies
since that's only added ifhelper_method
exists.Example error:
This adds the helper method to jbuilder to ensure that caching still works without having to include Helpers in API controllers.
Previously, this worked because you could include both the Helpers and Caching modules in API controllers in the correct order.
jbuilder doesn't have a test/dummy app to write tests for this.