Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding spec files in rubocop.yml #17

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nehamand
Copy link

For those of us who use Rspec instead of minitest, adding the spec/**/* files in rubocop.yml, for them to be consistent with the rest of the rails app.

@dayyan
Copy link

dayyan commented Oct 29, 2024

Hi @nehamand you can do do this locally to merge your changes with omakase:

# Omakase Ruby styling for Rails
inherit_gem: { rubocop-rails-omakase: rubocop.yml }

# Overwrite or add rules to create your own house style
#
# # Use `[a, [b, c]]` not `[ a, [ b, c ] ]`
# Layout/SpaceInsideArrayLiteralBrackets:
#   Enabled: false

inherit_mode:
  merge:
    - Include
    - Exclude

Performance:
  Exclude:
    - "spec/**/*"

Rails/AssertNot:
  Include:
    - "spec/**/*"

Rails/RefuteMethods:
  Include:
    - "spec/**/*"

Style/StringLiterals:
  Include:
    - "spec/**/*"

@@ -168,11 +169,13 @@ Performance/UnfreezeString:
Rails/AssertNot:
Include:
- "test/**/*"
- "spec/**/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this apply to rspec?


# Prefer assert_not_x over refute_x
Rails/RefuteMethods:
Include:
- "test/**/*"
- "spec/**/*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant for rspec?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants