Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up typos in /test, made some public methods in Connections module private #232

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Clean up typos in /test, made some public methods in Connections module private #232

merged 1 commit into from
Oct 22, 2024

Conversation

rossme
Copy link
Contributor

@rossme rossme commented Oct 20, 2024 •
edited
Loading

  • Cleaned up typos in /test/..
  • Made some public methods in lib/solid_cache/store/connections.rb private.
  • Renamed the inner entries to grouped_entries and grouped_keys in lib/solid_cache/store/connections.rb.

@rossme rossme changed the title Clean up tests, made some public methods in Connections module private Clean up typos in test, made some public methods in Connections module private Oct 20, 2024
@rossme rossme changed the title Clean up typos in test, made some public methods in Connections module private Clean up typos in /test, made some public methods in Connections module private Oct 21, 2024
@djmb djmb merged commit c342933 into rails:main Oct 22, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rossme @djmb