Conversation
byroot
force-pushed
the
update-ci
branch
3 times, most recently
from
4bd0706 to
fe84d24
Compare
| if config.include?("config.cache_classes") | ||
| config.sub!(/config\.cache_classes\s*=\s*false/, "config.cache_classes = true") | ||
| else # 7.1+ doesn't have config.cache_classes in the config at all | ||
| config.sub!(/config.enable_reloading = true/, "config.enable_reloading = true\nconfig.cache_classes = true") |
There was a problem hiding this comment.
This is confusing
Why set both enable_reloading and cache_classes?
The settings are basically aliases but opposite. enable_reloading = !cache_classes.
The Rails documentation is confusing in its description of enable_reloading and cache_classes, so maybe that is why it ended up this way here.
Suggested change
| config.sub!(/config.enable_reloading = true/, "config.enable_reloading = true\nconfig.cache_classes = true") | |
| config.sub!(/config.enable_reloading = true/, "config.enable_reloading = false") |
| if c.include?("config.cache_classes") | ||
| c.sub!(/config\.cache_classes\s*=\s*true/, "config.cache_classes = false") | ||
| else # 7.1+ doesn't have config.cache_classes in the config at all | ||
| c.sub!(/config.enable_reloading = false/, "config.enable_reloading = false\nconfig.cache_classes = false") |
There was a problem hiding this comment.
Same as in acceptance_test.rb
Suggested change
| c.sub!(/config.enable_reloading = false/, "config.enable_reloading = false\nconfig.cache_classes = false") | |
| c.sub!(/config.enable_reloading = false/, "config.enable_reloading = true") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.