Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert auth templates for Rails 8 beta1 #409

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Revert auth templates for Rails 8 beta1 #409

wants to merge 1 commit into from
+0 −69

Conversation

flavorjones
Copy link
Member

@flavorjones flavorjones commented Oct 1, 2024 •
edited
Loading

Do not merge until Rails 8 beta2 is released.

Reverts part of #408 which fixed #407's backwards-incompatible change.

@flavorjones flavorjones mentioned this pull request Oct 1, 2024
Merged
@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch 3 times, most recently from 7c46d2e to d209685 Compare October 1, 2024 23:21
@flavorjones
Copy link
Member Author

The failure on upstream / user-journey (rails v8.0.0.beta1) is expected; once beta2 is out I'll bump the matrix and this should go green.

@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch 2 times, most recently from 3e9d13c to ce18144 Compare October 2, 2024 12:54
@flavorjones flavorjones force-pushed the flavorjones-rails8beta1-auth-templates-revert branch from ce18144 to d6fa987 Compare October 2, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flavorjones