Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repeatable hash type flags bugfix. #769

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

patrick-motard
Copy link

@patrick-motard patrick-motard commented Jan 17, 2022

They treated like every other type now. Instead of merging each key/val
into a hash, each flag is treated like it's own hash that should be put
into an array.

fixes #768

🌈

They treated like every other type now. Instead of merging each key/val
into a hash, each flag is treated like it's own hash that should be put
into an array.

fixes rails#768
@dorner
Copy link

dorner commented Jan 18, 2022

Nice! Looks good to me - @rafaelfranca ?

@patrick-motard
Copy link
Author

bump

@wwwbruno
Copy link

Any updates on this fix? I faced this issue and this solves my problem.

@rafaelfranca
Copy link
Member

This is a change in the behavior and people might be expecting the option to merge instead of having two hashes. I don't think I can accept this change as is. I totally get the current behavior isn't what you want, but we can't assume it is broken and don't have a way to have it.

I'd accept an option that would allow the behavior you want though.

Copy link
Member

@rafaelfranca rafaelfranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above comment

@rafaelfranca rafaelfranca added needs-info Not enough detail to understand the issue need-work and removed needs-info Not enough detail to understand the issue labels May 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hash type is not supported by the repeatable option.
4 participants