Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return subcommand if its already registered #883

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Return subcommand if its already registered #883

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions lib/thor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,6 +327,8 @@ def subcommand_classes
end

def subcommand(subcommand, subcommand_class)
return subcommand_classes[subcommand.to_s] if subcommands.include? subcommand.to_s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to return the command class? It seems we only need to not register the command again. But what happens if people wants to override the subcommand to have different code? Let's say a library trying to enhance an already existing class. It seems that would break that behavior.


subcommands << subcommand.to_s
subcommand_class.subcommand_help subcommand
subcommand_classes[subcommand.to_s] = subcommand_class
Expand Down