Merge pull request #342 from zunda/bind-on-ipv6

Always permit IPv4-mapped IPv6 loopback addresses
rails · Dec 19, 2024 · 859bc60 · 859bc60
2 parents f3d437c + c66460a
commit 859bc60
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/lib/web_console/permissions.rb b/lib/web_console/permissions.rb
@@ -5,7 +5,7 @@
 module WebConsole
   class Permissions
     # IPv4 and IPv6 localhost should be always allowed.
-    ALWAYS_PERMITTED_NETWORKS = %w( 127.0.0.0/8 ::1 )
+    ALWAYS_PERMITTED_NETWORKS = %w( 127.0.0.0/8 ::1 ::ffff:127.0.0.0/104 )
 
     def initialize(networks = nil)
       @networks = normalize_networks(networks).map(&method(:coerce_network_to_ipaddr)).uniq

diff --git a/test/web_console/permissions_test.rb b/test/web_console/permissions_test.rb
@@ -9,6 +9,7 @@ class PermissionsTest < ActiveSupport::TestCase
 
       assert_includes permissions, "127.0.0.1"
       assert_includes permissions, "::1"
+      assert_includes permissions, "::ffff:127.0.0.1"
     end
 
     test "permits single IPs" do
@@ -41,7 +42,7 @@ class PermissionsTest < ActiveSupport::TestCase
     end
 
     test "human readable presentation" do
-      assert_includes permit.to_s, "127.0.0.0/127.255.255.255, ::1"
+      assert_includes permit.to_s, "127.0.0.0/127.255.255.255, ::1, ::ffff:127.0.0.0/::ffff:127.255.255.255"
     end
 
     private