Rspec Added for Testing #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s for Users controllers. Tests for show, new, and create methods are included. User_spec file includes test for User model. All tests are currently passing in pending status.The spec directory which includes the rails_helper and spec_helper files is created as part of the rspec install. More tests will be added and refined as we continue to add to the project.
|
I think this is a really good start! check my note on the last commit about test syntax but otherwise I think these are ready for you to write some tests 👍 I would just keep working on this PR and we'll merge it once we have some working tests. |
…dding changes to user.rb and user_spec.rb files. Updated rails_helper.rb and spec_helper files for Factory Girl gems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added Rspec to the project to use for testing. I created tests for the User model and Users Controller. The gemfile and gemfile.lock have both been updated to include the Rspec additions. A spec folder with Controllers and Models folders which include the spec files for both and a rails_helper spec_helper file are included.
The tests are a starting point, and we can add more and refactor as needed.