Update gemfile and dependencies #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mklocek
approved these changes
Aug 14, 2024
leonid-shevtsov
approved these changes
Aug 15, 2024
| @@ -21,7 +21,7 @@ Gem::Specification.new do |spec| | |||
| spec.metadata['changelog_uri'] = 'https://github.com/railsware/actionmailer-balancer/blob/main/CHANGELOG.md' | |||
| spec.metadata['rubygems_mfa_required'] = 'true' | |||
|
|
|||
| spec.add_runtime_dependency 'actionmailer', '> 4.0', '< 8.0' | |||
| spec.add_dependency 'actionmailer', '> 4.0', '< 8.0' | |||
There was a problem hiding this comment.
do you know why it was add_runtime_dependency before?
There was a problem hiding this comment.
add_runtime_dependency is the same thing. apparently back then there were no such rule in Rubocop probably.
IgorDobryn
approved these changes
Aug 16, 2024
mklocek
reviewed
Aug 19, 2024
Gemfile.lock
Outdated
Comment on lines
87
to
88
| nokogiri (1.15.6) | ||
| mini_portile2 (~> 2.8.2) |
There was a problem hiding this comment.
Could we bump nokogiri too? https://github.com/railsware/actionmailer-balancer/security/dependabot/30
There was a problem hiding this comment.
Damn me! I did that but because I decided to keep the older ruby version support later on the change got overwritten. Thanks for bringing that up!
IgorDobryn
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
developmentgroup.gitignorerubocop-rakeHow to test
actionmailer-balancerand do quick smoke test