Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Email testing #24

Merged
merged 37 commits into from
Nov 10, 2023
Merged

Email testing #24

merged 37 commits into from
Nov 10, 2023

Conversation

narekhovhannisyan
Copy link
Collaborator

@narekhovhannisyan narekhovhannisyan commented Oct 27, 2023 •
edited
Loading

Motivation

Implement email testing API and Inboxes, Projects, Messages resources.

Changes

  • Separated axios error handler.
  • Initialized Testing, Inboxes, Messages and Projects resources.
  • Added usage samples.

@narekhovhannisyan
config: init testing error messages and endpoints.
98bd5aa
@narekhovhannisyan
lib: init axios logger.
715205b
@narekhovhannisyan
lib: add testing api functionality to mailtrap
4b9a8c5 
 client.
@narekhovhannisyan
lib: in axios-logger logically separate imports.
3923686
@narekhovhannisyan
api: implement email testing.
a7aee12
@narekhovhannisyan
api: implement testing inboxes.
c581c89
@narekhovhannisyan
api: implement testing messages.
29ba6e8
@narekhovhannisyan
api: implement testing projects.
da217e3
@narekhovhannisyan
types: update mailtrap client config.
f8f3a56
@narekhovhannisyan
types: init projects api.
d95b86a
@narekhovhannisyan
api: tune inbox resource to use types,
a54271d 
fix account id injection issue.
@narekhovhannisyan
api: tune projects resource to use types.
20ce348
@narekhovhannisyan
types: init axios.
fb40717
@narekhovhannisyan
lib: tune axios logger to handle more errors
5048328 
 scenarios.
@narekhovhannisyan
types: init inboxes.
64e3f3e
@narekhovhannisyan
types: reuse inboxes types in projects.
1fa1c36
@narekhovhannisyan
examples: init projects api usage.
346f9a8
@narekhovhannisyan
examples: init inboxes api usage.
d4b1b13
@narekhovhannisyan
examples: in inboxes ad newline at the end of file
6d173a8
@narekhovhannisyan
api: in testing temporary disable warn.
a6d7010
@narekhovhannisyan
tests: support mailtrap client new config.
f51d5cc
VladimirTaytor
VladimirTaytor reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@VladimirTaytor VladimirTaytor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general left few suggestions 👌

examples/testing-api/inboxes.ts Outdated Show resolved Hide resolved
src/lib/api/Testing.ts Outdated Show resolved Hide resolved
VladimirTaytor
VladimirTaytor approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@VladimirTaytor VladimirTaytor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, would be nice to test everything manually before delivering a new release

examples/testing/inboxes.ts Outdated Show resolved Hide resolved
mklocek
mklocek approved these changes Nov 7, 2023
View reviewed changes
src/lib/api/resources/Inboxes.ts Outdated Show resolved Hide resolved
src/lib/axios-logger.ts Show resolved Hide resolved
@narekhovhannisyan narekhovhannisyan merged commit 3af12a3 into main Nov 10, 2023
1 check passed
@narekhovhannisyan narekhovhannisyan deleted the email-testing branch November 10, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonid-shevtsov leonid-shevtsov leonid-shevtsov approved these changes

@mklocek mklocek mklocek approved these changes

@VladimirTaytor VladimirTaytor VladimirTaytor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@narekhovhannisyan @leonid-shevtsov @mklocek @VladimirTaytor