Bulk sending api #39
Merged
Bulk sending api #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narekhovhannisyan
requested review from
leonid-shevtsov,
vittorius and
VladimirTaytor
vittorius
reviewed
May 20, 2024
VladimirTaytor
approved these changes
May 20, 2024
examples/bulk-sending/send-mail.ts
Outdated
| import { MailtrapClient } from "mailtrap" | ||
|
|
||
| /** | ||
| * For this example to work, you need to set up a sending domain, |
There was a problem hiding this comment.
Suggested change
| * For this example to work, you need to set up a sending domain, | |
| * For this example, you need to have ready-to-use sending domain |
We introduced feature called Demo domain, so all new accounts have a pre-created domain to test sending, we might change wording here
- or we can double check with Tudor
vittorius
reviewed
May 22, 2024
vittorius
approved these changes
Jun 10, 2024
vittorius
approved these changes
Jun 10, 2024
Co-authored-by: Victor Zagorodny <post.vittorius@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add support for Bluk Sending API to SDK.
Changes