fix: npm alias parsing with complex version strings #1319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 25, 2023
Cherry
force-pushed
the
fix/github-parse-throw
branch
from
f719cfa
to
9b15f52
Compare
|
Beautiful, thanks! I'm on vacation without a computer this weekend, so I'll publish the patch on Monday. |
|
Awesome, thank you! The failing tests seem to be unrelated to my changes. |
raineorshine
force-pushed
the
fix/github-parse-throw
branch
from
9b15f52
to
545bb37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseGithubURL('npm:chalk@1.0.0')returnsnull, whereasparseGithubURL('npm:chalk@1.0.0-dasda.2')throws an error in Node 18.17+.This would mean that dependencies like
npm:postman-request@2.88.1-postman.33would crash the process with anERR_INVALID_URLerror.For details on the Node.js regression, see nodejs/node#49330. Given how
url.parseis a deprecated stability-0 method though, it's very possible this won't be fixed. Thus handling it here with atry...catchmight be the best solution.Fixes #1318