Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update 1-dotrain-in-10-minutes.svelte.md #58

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update 1-dotrain-in-10-minutes.svelte.md #58

wants to merge 3 commits into from

Conversation

dcatki
Copy link
Contributor

@dcatki dcatki commented Oct 21, 2024

Intro to dotrain

Motivation

Intro to dotrain

Solution

Checks

By submitting this for review, I'm confirming I've done the following:

  • made this PR as small as possible
  • unit-tested any new functionality
  • linked any relevant issues or PRs

@dcatki dcatki requested a review from hardyjosh October 21, 2024 01:07
@dcatki dcatki added the documentation Improvements or additions to documentation label Oct 21, 2024
@dcatki dcatki self-assigned this Oct 22, 2024
hardyjosh
hardyjosh requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@hardyjosh hardyjosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall seems quite confusing - the third most important key objective is to be 1:1 with a CBOR sequence?

Illustrative examples would help alot

@dcatki
Copy link
Contributor Author

dcatki commented Nov 14, 2024

@Siddharth2207 maybe this is something we can spend 10 minutes on together first, and then i willl come and edit

@vercel Vercel
Copy link

vercel bot commented Nov 15, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs-rainlang-xyz ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 4:20am

@dcatki
Copy link
Contributor Author

dcatki commented Nov 16, 2024

updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardyjosh hardyjosh hardyjosh requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@dcatki dcatki

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcatki @hardyjosh @Siddharth2207