Fixed performance issue with non-scrollable content (#219)

rajdeep · Aug 25, 2023 · 3c10be0 · 3c10be0
1 parent df31a9c
commit 3c10be0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/Proton/Sources/Swift/Attachment/Attachment.swift b/Proton/Sources/Swift/Attachment/Attachment.swift
@@ -474,9 +474,10 @@ extension Attachment {
               let range = editor.attributedText.rangeFor(attachment: self)
         else { return }
         cachedBounds = nil
+        let needsInvalidation = bounds.integral.size != contentView?.bounds.integral.size
         editor.invalidateLayout(for: range)
 
-        if containerTextView?.isScrollEnabled == false {
+        if containerTextView?.isScrollEnabled == false, needsInvalidation {
             containerTextView?.invalidateIntrinsicContentSize()
         }
     }

diff --git a/Proton/Sources/Swift/Core/RichTextView.swift b/Proton/Sources/Swift/Core/RichTextView.swift
@@ -87,13 +87,6 @@ class RichTextView: AutogrowingTextView {
         }
     }
 
-    override func layoutSubviews() {
-        super.layoutSubviews()
-        if editorView?.isRootEditor == true, editorView?.isScrollEnabled == false {
-            invalidateIntrinsicContentSize()
-        }
-    }
-
     override var selectedTextRange: UITextRange? {
         didSet{
             let old = oldValue?.toNSRange(in: self)

diff --git a/Proton/Sources/Swift/Grid/View/GridCell.swift b/Proton/Sources/Swift/Grid/View/GridCell.swift
@@ -183,7 +183,7 @@ public class GridCell {
     }
 
     public convenience init(rowSpan: [Int], columnSpan: [Int], initialHeight: CGFloat = 40, style: GridCellStyle = .init(), gridStyle: GridStyle = .default) {
-        self.init(editor: EditorView(), rowSpan: rowSpan, columnSpan: columnSpan, initialHeight: initialHeight, style: style, gridStyle: gridStyle)
+        self.init(editor: EditorView(allowAutogrowing: false), rowSpan: rowSpan, columnSpan: columnSpan, initialHeight: initialHeight, style: style, gridStyle: gridStyle)
     }
 
     /// Sets the focus in the `Editor` within the cell.