Support new binary i64 data type from HOI4 1.13 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new data type can be seen in HOI4 1.13 saves as
```
manpower = { ratio = 81900 }
```
This datatype technically conflicts with some detected tokens in
Imperator and Vic3 (`playbackrate`), but I believe this token to be
unused and shouldn't pose too much of a problem.
I determined that it was signed 64bit by editing the binary to turn all
bits on and I saw the output as -1.
This is a breaking change as `BinaryToken` is receiving an addition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new data type can be seen in HOI4 1.13 saves as
This datatype technically conflicts with some detected tokens in Imperator and Vic3 (
playbackrate), but I believe this token to be unused and shouldn't pose too much of a problem.I determined that it was signed 64bit by editing the binary to turn all bits on and I saw the output as -1.
This is a breaking change as
BinaryTokenis receiving an addition.