Allow direct struct field matching from binary token #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbabcock
force-pushed
the
direct
branch
3 times, most recently
from
24f372f to
3d7c694
Compare
nickbabcock
force-pushed
the
direct
branch
2 times, most recently
from
7fb7cd9 to
21a6f73
Compare
The binary token resolution leaves some efficiency on the table as it
first translates the token to a string and then matches the string
against struct fields.
The PR asks the question, what if we reduce the operation to just
matching on the 16bit value? Remove the translation step and simplify
matching.
This is what I envision and technically now works in this PR:
```rust
struct MyStruct {
#[jomini(token = 0x2d82)]
field1: String,
}
```
Large caveats:
- Direct matching is only done when the string resolution fails
- And must use `FailedResolveStrategy::Visit`
The first caveat is the largest problem as we don't want to remove
tokens from the token list because token resolution needs to work on
values (they aren't always keys).
I think the best course of action will be to classify each struct as if
fields can be directly resolved or if it needs translation based on the
presence of the `#[jomini(token)]` attribute.
For direct structs, swap the request to `deserialize_identifier` to
`deserialize_u16` to give a hint that tokens should not be resolved.
Some unanswered questions:
- Do the efficiency gains justify the complication?
- I know PDS doesn't want the token list revealed, I wonder if this is
obfuscated enough to be ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The binary token resolution leaves some efficiency on the table as it first translates the token to a string and then matches the string against struct fields.
The PR asks the question, what if we reduce the operation to just matching on the 16bit value? Remove the translation step and simplify matching.
This is what I envision and technically now works in this PR:
Large caveats:
classify each struct if fields can be directly resolved or if it needs translation based on the presence of the
#[jomini(token)]attribute.For direct structs, swap the request to
deserialize_identifiertodeserialize_u16to give a hint that tokens should not be resolved.Some unanswered questions: