Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix allow negative dates with from [-100,-999] #129

Merged
merged 1 commit into from
Nov 12, 2023
Merged

Conversation

nickbabcock
Copy link
Contributor

A bug exists where a date like -100.11.12 will be incorrectly parsed as the fast path fails and then fallsback to trying to parse the synthetic input for the fast path.

This code fixes this by having the fast path return none in the advent that it can't handle the input.

Benchmarks remain unaffected.

A bug exists where a date like `-100.11.12` will be incorrectly parsed
as the fast path fails and then fallsback to trying to parse the
synthetic input for the fast path.

This code fixes this by having the fast path return none in the advent
that it can't handle the input.

Benchmarks remain unaffected.
@nickbabcock nickbabcock merged commit 25db2e5 into master Nov 12, 2023
7 checks passed
@nickbabcock nickbabcock deleted the fix-date branch November 12, 2023 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant