Writing operator switches to object mode. Trim spaces around equal op #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If someone is using the writer but doesn't know what the upcoming container type is (array, object, mixed). There is no way to switch without peeking. This allows the writer to always start with an array and then if an operator is encountered (like an equals operator), the container will be switched to object mode And if equals is being written, there shouldn't be any spaces around it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If someone is using the writer but doesn't know what the upcoming container type is (array, object, mixed). There is no way to switch without peeking. This allows the writer to always start with an array and then if an operator is encountered (like an equals operator), the container will be switched to object mode
And if equals is being written, there shouldn't be any spaces around it.