Reorganize reader refill logic #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracting the refill logic into a separate function makes the code less nested without resorting to `call`s that risk a stack overflow. Changing the binary reader inner functions to return `Result<Option<_>>`, instead of two options netted a 5% throughput improvement on EU4 save melting. The two options were originally introduced as their was a large benefit measured. I don't know what happened, perhaps reorganizing the refill logic is a boon. The text reader internal return types haven't been modified as they still show a 5% improvement over the `Result<Option<_>>` alternative.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracting the refill logic into a separate function makes the code less nested without resorting to
calls that risk a stack overflow.Changing the binary reader inner functions to return
Result<Option<_>>, instead of two options netted a 5% throughput improvement on EU4 save melting. The two options were originally introduced as their was a large benefit measured. I don't know what happened, perhaps reorganizing the refill logic is a boon.The text reader internal return types haven't been modified as they still show a 5% improvement over the
Result<Option<_>>alternative.