Add ProgressView #82
Open
Add ProgressView #82
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinwl02
suggested changes
Jun 7, 2021
| progressView.setProgress(progress ?? 0, animated: true) | ||
| } | ||
|
|
||
| if let uiStackView = view as? UIStackView { |
There was a problem hiding this comment.
you can add else to this if condition so the flow is clearer.
if let progressView = view as? UIProgressView {
} else if let uiStackView = view...
|
|
||
| extension ProgressView: Renderable { | ||
| public func createView(context: Context) -> UIView { | ||
| if (progress != nil) { |
There was a problem hiding this comment.
You can move this 4 view creation flows to a separate function each, and call them from this function, in order to make this one cleaner.
kevinwl02
suggested changes
Jun 7, 2021
| if (progress != nil) { | ||
| /// Determinate Progress View | ||
| if (title != nil) { | ||
| let titleView = UITextView() |
There was a problem hiding this comment.
You can use a UILabel instead of a TextView. A text view can have the contents edited directly by the user (I think this is not the intended behavior right?)
| let indicatorView = UIActivityIndicatorView(style: .whiteLarge) | ||
| indicatorView.color = .gray | ||
| indicatorView.startAnimating() | ||
| let titleView = UITextView() |
There was a problem hiding this comment.
Same here, you can use a label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.