wip

rakutentech · Sep 21, 2024 · 2393ae3 · 2393ae3
1 parent ef8479e
commit 2393ae3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/...ava/com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/ApplyClickableImage.kt b/...ava/com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/ApplyClickableImage.kt
@@ -19,11 +19,8 @@ internal fun UiMessage.applyCustomClickableImage(clickableImage: ClickableImage?
             return false
         }
 
-        return if (this.startsWith("http")) {
-            Regex("https://.*").matches(this)
-        } else {
-            Regex(".*://.*").matches(this)
-        }
+        val allowedPattern = Regex("https://.*|.*://.*")
+        return this.matches(allowedPattern)
     }
 
     @SuppressWarnings("ComplexCondition")

diff --git a/...com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/ApplyClickableImageSpec.kt b/...com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/ApplyClickableImageSpec.kt
@@ -31,7 +31,7 @@ class ApplyClickableImageSpec {
         uiMessage = message.applyCustomClickableImage(ClickableImage("ogle.124dsefsd"), false)
         uiMessage shouldBeEqualTo message
 
-        uiMessage = message.applyCustomClickableImage(ClickableImage("http://test.com"), false)
+        uiMessage = message.applyCustomClickableImage(ClickableImage("intent:/invalid/deeplink"), false)
         uiMessage shouldBeEqualTo message
 
         uiMessage = message.applyCustomClickableImage(ClickableImage("   myapp://open"), false)