Skip to content

improve: save config settings in sample app cache (SDKCF-6887) #374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maureenorea-clores
Copy link
Collaborator

Description

For testing app relaunches with runtime configuration (sample app update only)

Links

N/A

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

Copy link

sonarqubecloud bot commented Mar 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@maureenorea-clores maureenorea-clores marked this pull request as ready for review March 1, 2024 02:27
@rakutentech-danger-bot
Copy link
Collaborator

2 Warnings
⚠️ Tests were not updated.
⚠️ PR title "improve: save config settings in sample app cache" should append ticket number(s).

JaCoCo Code Coverage 97.6% ✅

Class Covered Meta Status

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores changed the title improve: save config settings in sample app cache improve: save config settings in sample app cache (SDKCF-6887) Mar 1, 2024
@maureenorea-clores maureenorea-clores merged commit d22243e into rakutentech:master Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants