Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: image glitch and add url validations (RMCCX-7331, RMCCX-7345) #395

Merged
merged 16 commits into from
Sep 20, 2024
Merged

fix: image glitch and add url validations (RMCCX-7331, RMCCX-7345) #395

merged 16 commits into from
Sep 20, 2024

Conversation

maureenorea-clores
Copy link
Collaborator

@maureenorea-clores maureenorea-clores commented Sep 20, 2024 •
edited
Loading

Description

Supplement of RMCCX-7186

Links

N/A

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

maureenorea-clores and others added 15 commits August 22, 2024 16:42
@maureenorea-clores
improve: add console logging (RMCCX-6876)
e03c931
@maureenorea-clores
Merge branch 'master' of https://github.com/rakutentech/android-inapp…
9ae679f 
…messaging into release/v7.7.0
@maureenorea-clores
feat: [RMC] support clickable image through CustomJson (RMCCX-7186)
739d266
@maureenorea-clores
Merge branch 'master' of https://github.com/rakutentech/android-inapp…
7a1e8a4 
…messaging into release/v7.7.0

# Conflicts:
#	inappmessaging/USERGUIDE.md
@maureenorea-clores
fix: glitch behavior when clicking content image (RMCCX-7331)
8a7781b
@maureenorea-clores
wip
71ee20e
@maureenorea-clores
Merge branch 'master' of https://github.com/maureenorea-clores/androi…
b732fba 
…d-inappmessaging into fix/RMCCX-7331_image-glitch

# Conflicts:
#	inappmessaging/src/main/java/com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/ApplyClickableImage.kt
#	inappmessaging/src/main/java/com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessageBaseView.kt
@maureenorea-clores
wip
d6d2c2f
@maureenorea-clores
wip
ce7a996
@maureenorea-clores
revert
db514d1
@maureenorea-clores
wip
83e0da9
@maureenorea-clores
update
b154d94
@maureenorea-clores
wip
ad26411
@maureenorea-clores
wip
8f9dede
@maureenorea-clores
wip
4c6614d
mdusmangani-jp
mdusmangani-jp approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rakutentech-danger-bot
Copy link
Collaborator

2 Warnings
⚠️ Branch name "fix/RMCCX-7331_image-glitch" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>.
⚠️ PR title "fix: image glitch and add url validations (RMCCX-7331, RMCCX-7345)" should append ticket number(s).

JaCoCo Code Coverage 97.58% ✅

Class Covered Meta Status
com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessageBaseView 89% 0% ✅
com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessageViewListener 94% 0% ✅

Generated by 🚫 Danger

@maureenorea-clores maureenorea-clores merged commit 4a4ffba into rakutentech:master Sep 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdusmangani-jp mdusmangani-jp mdusmangani-jp approved these changes

@leila-gu leila-gu Awaiting requested review from leila-gu leila-gu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maureenorea-clores @rakutentech-danger-bot @mdusmangani-jp