Change DLS datafile create time to datafileCreateTime #1664 #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
louise-davies
force-pushed
the
gfi-1664
branch
from
370f680
to
4aa7152
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1668 +/- ##
========================================
Coverage 95.35% 95.35%
========================================
Files 182 182
Lines 7844 7844
Branches 2482 2493 +11
========================================
Hits 7480 7480
Misses 329 329
Partials 35 35
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- also improve datafilePreview e2e tests
joelvdavies
previously approved these changes
Sep 2, 2024
joshuadkitenge
previously approved these changes
Sep 2, 2024
louise-davies
dismissed stale reviews from joshuadkitenge and joelvdavies
via
4e34c0c
louise-davies
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switch out the column definition for createTime to datafileCreateTime.
Make the change for ISIS
update the type definition for Datafile
Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
Closes #1664