refactor: removed unnecessary check

ralvarezdev · Jan 5, 2025 · 5a50305 · 5a50305
1 parent b5a27f0
commit 5a50305
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 21 deletions.
diff --git a/cloud/gcloud/logger.go b/cloud/gcloud/logger.go
@@ -1,7 +1,6 @@
 package gcloud
 
 import (
-	gologger "github.com/ralvarezdev/go-logger"
 	gologgermode "github.com/ralvarezdev/go-logger/mode"
 	gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
 	"google.golang.org/grpc/credentials/oauth"
@@ -14,13 +13,11 @@ type Logger struct {
 
 // NewLogger is the logger for Google Cloud
 func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
-	// Check if the logger is nil
-	if modeLogger == nil {
-		return nil, gologger.ErrNilLogger
-	}
-
 	// Initialize the mode named logger
-	namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	if err != nil {
+		return nil, err
+	}
 
 	return &Logger{logger: namedLogger}, nil
 }

diff --git a/env/logger.go b/env/logger.go
@@ -1,7 +1,6 @@
 package env
 
 import (
-	gologger "github.com/ralvarezdev/go-logger"
 	gologgermode "github.com/ralvarezdev/go-logger/mode"
 	gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
 )
@@ -13,13 +12,11 @@ type Logger struct {
 
 // NewLogger creates a new environment logger
 func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
-	// Check if the logger is nil
-	if modeLogger == nil {
-		return nil, gologger.ErrNilLogger
-	}
-
 	// Initialize the mode named logger
-	namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	if err != nil {
+		return nil, err
+	}
 
 	return &Logger{logger: namedLogger}, nil
 }

diff --git a/http/listener/logger.go b/http/listener/logger.go
@@ -1,7 +1,6 @@
 package listener
 
 import (
-	gologger "github.com/ralvarezdev/go-logger"
 	gologgermode "github.com/ralvarezdev/go-logger/mode"
 	gologgermodenamed "github.com/ralvarezdev/go-logger/mode/named"
 )
@@ -13,13 +12,11 @@ type Logger struct {
 
 // NewLogger creates a new listener logger
 func NewLogger(header string, modeLogger gologgermode.Logger) (*Logger, error) {
-	// Check if the logger is nil
-	if modeLogger == nil {
-		return nil, gologger.ErrNilLogger
-	}
-
 	// Initialize the mode named logger
-	namedLogger, _ := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	namedLogger, err := gologgermodenamed.NewDefaultLogger(header, modeLogger)
+	if err != nil {
+		return nil, err
+	}
 
 	return &Logger{logger: namedLogger}, nil
 }