Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update blaster_db.py #9

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Coday-meric
Copy link

Blasters support RM4, RM4c, RM4 Pro and some RM3 blasters. Use rm4 class and get_type function.

Blasters support RM4, RM4c, RM4 Pro and some RM3 blasters. Use rm4 class and get_type function.
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Mar 1, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 1.45%.

Quality metrics Before After Change
Complexity 3.91 ⭐ 4.03 ⭐ 0.12 👎
Method Length 27.76 ⭐ 29.19 ⭐ 1.43 👎
Working memory 7.00 🙂 7.50 🙂 0.50 👎
Quality 80.41% 78.96% -1.45% 👎
Other metrics Before After Change
Lines 160 166 6
Changed files Quality Before Quality After Quality Change
app/db_helpers/blaster_db.py 80.41% ⭐ 78.96% ⭐ -1.45% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
app/db_helpers/blaster_db.py get_new_blasters 5 ⭐ 112 🙂 14 😞 55.83% 🙂 Extract out complex expressions
app/db_helpers/blaster_db.py Blaster.device 3 ⭐ 73 🙂 11 😞 68.01% 🙂 Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant