Try to add startup commands #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The general idea is to use the EEPROM. We check for exactness in the version and if the version matches we then run the startup commands as if they are coming from the serial port.
|
https://github.com/PaulStoffregen/LittleFS it is somewhat ideal since it gets wiped out?? |
|
hmm, this is somewhat of limited use since there is little feedback that can be created without an overseeing script.... |
|
I guess its kinda OK since we can use this to test EXTERNAL hardware. |
vetonsaliu8
reviewed
Nov 21, 2024
| int read_demo_command(CommandRouter *cmd, int argc, const char **argv); | ||
| int disable_demo_commands(CommandRouter *cmd, int argc, const char **argv); | ||
| int enable_demo_commands(CommandRouter *cmd, int argc, const char **argv); | ||
| int demo_commands_available(CommandRouter *cmd, int argc, const char **argv); |
There was a problem hiding this comment.
@hmaarrfk is this a duplicate?
vetonsaliu8
reviewed
Nov 21, 2024
| break; | ||
| } | ||
| } | ||
| parseInputBuffer(input_buffer, bytes_read, argv, argc); |
There was a problem hiding this comment.
is this right? argv is not declared anywhere in CommandRouter::processSerialStream
There was a problem hiding this comment.
They should be part of the class. I think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We check for exactness in the version and if the version matches we then run the startup commands as if they are coming from the serial port.
I'm not so much of a fan of using the EEPROM, i wish i could use the program memory.
New idea:
__attribute__((weak)))Let users use this as a library.The main purpose of this is to enable the setup of "safe" pins and "startup routines" that might not need error checking. If branching is required then this cannot be used as is.