Fix svg rendering #515
Fix svg rendering #515
Conversation
IshavSohal
added
the
PR: Frontend
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/svg-issues/#/en/00000000-0000-0000-0000-000000000000 |
There was a problem hiding this comment.
Looks like you made a few changes in Storylines that require a version update for the editor, so let me know if you want to publish these changes to a new NPM version and I can send you the steps. If changes not urgent, then we can also just include the changes in a future NPM version.
Reviewable status: 0 of 2 files reviewed, all discussions resolved
IshavSohal
force-pushed
the
svg-issues
branch
from
823c49c to
5c346f2
Compare
There was a problem hiding this comment.
Does the logic also need to be applied to the background-image.vue component?
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Does the logic also need to be applied to the
background-image.vuecomponent?
If we've already added in the support here for the introduction slide background image, I'd say we should add in the support for regular background images as well.
Side note, have we ever tested background images with using an SVG source?
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
Not that I am aware of
Reviewable status: 0 of 3 files reviewed, all discussions resolved
There was a problem hiding this comment.
I've applied the logic for regular background images as well. It seems to be working on my end, but let me know if there are any issues.
Reviewable status: 0 of 4 files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:
Related Item(s)
ramp4-pcar4/storylines-editor#436
Changes
Testing
This would have to be tested through the preview in the storylines editor.
This change is