Update build config, bump up ramp to v4.10.0 #524
Conversation
milespetrov
added
the
PR: Build
|
Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/story-ramp/build-update/#/en/00000000-0000-0000-0000-000000000000 |
There was a problem hiding this comment.
Reviewed 15 of 15 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @milespetrov)
There was a problem hiding this comment.
Great improvements 🏆
Only thing that I've found is that RAMP grid styling seems to have broken somehow:
Reviewed 14 of 15 files at r1, all commit messages.
Reviewable status:
milespetrov
force-pushed
the
build-update
branch
from
e4f7110 to
8388749
Compare
There was a problem hiding this comment.
Good catch, pointed to a more respectful css file
Reviewable status: 14 of 15 files reviewed, all discussions resolved (waiting on @james-rae and @RyanCoulsonCA)
There was a problem hiding this comment.
Reviewed 1 of 15 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Unless no storylines uses Custom Details Templating (can someone on the squad confirm or deny?), I think we need to block this until ramp4-pcar4/ramp4-pcar4#2535 can get fixed. Might need to do a patch release v4.10.1 since this PR needs something on npm.
Reviewable status:
There was a problem hiding this comment.
Found CWS storylines using custom templating here: Priority Places for Species at Risk - Canada.ca
Reviewed 14 of 15 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:
There was a problem hiding this comment.
v4.10.2 is published, will unblock once package is updated and things are working gud
Reviewable status:
milespetrov
force-pushed
the
build-update
branch
from
8388749 to
2c927fd
Compare
There was a problem hiding this comment.
Reviewed 11 of 15 files at r1, 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
All seems well, typescript typings are also working in VS Code 👍
Reviewable status:
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, 3 of 3 files at r3, all commit messages.
Reviewable status:
There was a problem hiding this comment.
Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status:
Changes
Notes
This PR bumps ramp to v4.10.0 and updates some repo and build level configs. Initial download is now 3.4 MB, down from 5 MB due to ramp esDynamic improvements. The initial size of this library can be further reduced once we identify and implement appropriate dynamic imports.
Vite is stuck at v5 due to
vite-plugin-static-copy. Looks like that lib gets updated regularly so we can wait a bit for a patch to v6. Might also make sense to just use thecpcommand.This change is