Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Vue 3 router redirect #282

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

yileifeng
Copy link
Member

@yileifeng yileifeng commented Apr 12, 2024

Related Item(s)

Closes #277

Changes

  • [FIX] router redirect for the '/:lang/editor/:uid' route to correctly redirect to metadata page for given UID

Testing

Steps:

  1. Load https://ramp4-pcar4.github.io/storylines-editor/fix-router-redirect/#/en/editor/00000000-0000-0000-0000-000000000000
  2. Test that redirected page to metadata is working and loads product

This change is Reviewable

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/fix-router-redirect/#/en/editor

Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

Copy link
Member

@KashishMistry KashishMistry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @yileifeng)

@yileifeng yileifeng merged commit 62e26ca into ramp4-pcar4:main Apr 18, 2024
3 checks passed
@yileifeng yileifeng deleted the fix-router-redirect branch April 18, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading existing product via /editor/<uid> is broken
4 participants