Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality to edit button, sort products by last modifed #432

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

IshavSohal
Copy link
Member

@IshavSohal IshavSohal commented Nov 27, 2024

Related Item(s)

#461
#446

Changes

  • Open the editor for a product upon clicking its corresponding Edit button (within the dashboard)
  • Sort the products of the 'Previously Edited Products' table by last modified date (most recently modified products displayed first)

Testing

Steps:

  1. Open the dashboard
  2. Observe that the products of the 'Previously Edited Products' table by last modified date
  3. Click the Edit button for product 00000000-0000-0000-0000-000000000000
  4. Observe that you are redirected to the editor

This change is Reviewable

@IshavSohal IshavSohal added the PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review. label Nov 27, 2024
Copy link
Member Author

@IshavSohal IshavSohal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion


src/components/home.vue line 178 at r1 (raw file):

        this.currLang = (this.$route.params.lang as string) || 'en';
        this.sourceFile = window.location.href.split('/').find((s) => s.includes('#'));
        // this.userStore

Demo blocker

Copy link

Your demo site is ready! 🚀 Visit it here: https://ramp4-pcar4.github.io/storylines-editor/dashboard-redesign

@IshavSohal IshavSohal changed the title Add functionality to edit button Add functionality to edit button, sort products by last modifed Nov 28, 2024
Copy link
Member

@RyanCoulsonCA RyanCoulsonCA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

Copy link
Member

@szczz szczz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)

Copy link
Member

@spencerwahl spencerwahl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @RyanCoulsonCA and @yileifeng)

Copy link
Member

@yileifeng yileifeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @IshavSohal)

@yileifeng yileifeng merged commit cb26d3e into ramp4-pcar4:main Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Frontend PR that primarily involves frontend changes. UI experts and CSS Wizards are asked to review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants