Skip to content

Enable multithreaded compilation for ps2EntryRunner with MSVC /MP flag #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PlasteredCrab wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable multithreaded compilation for ps2EntryRunner with MSVC /MP flag #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ps2xRuntime/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ add_executable(ps2EntryRunner
)

if(MSVC)
target_compile_options(ps2EntryRunner PRIVATE /FS)
target_compile_options(ps2EntryRunner PRIVATE /FS /MP4)
Copy link
Owner

@ran-j ran-j Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok we have 2 problems here.

First is a hardcode 4. My pc has like 12 cores so using 4 will be ass for me.

You are only applying this to msvc but a lot of people use other compilers

Copy link
Author

@PlasteredCrab PlasteredCrab Feb 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah sorry Edgar told me 4 would be better for weaker PCs haha. A command argument to specify the amount of cores or max cores was suggested as well which we could do instead!

endif()

target_include_directories(ps2_runtime PUBLIC
Expand Down