Assign TenantID to managed cluster identity #144
Conversation
|
@MAXxATTAXx could you provide us instruction, how can we reproduce your scenario? We would like to test it as well. Thank you so much for opening this PR |
|
In our scenario, we have new environments spawned in exernal Azure tenats to our system. They allow us access on a particular resource_group to deploy and manage an aks cluster. The Service Principal or ClientID belongs to us so the tenantID of the ClientID is different than the tenantID of the resource_group. In azure world it is called Managed Resource Group or Managed Applications. |
|
@MAXxATTAXx can you take a look at #144 (comment) and address the comment? |
|
This looks good to me, @MAXxATTAXx can we add some simple tests as well? |
|
@furkatgofurov7 |
@MAXxATTAXx thanks, lgtm, can you please squash your commits? @mjura PTAL once again |
|
@furkatgofurov7 Commits squashed and rebased to master |
This allows for cloudCredentials to be provisioned in a different tenant than the cluster. This is useful for scenarios where the cluster is provisioned in a tenant that is not the same as the tenant that the credentials are provisioned in.
|
@mjura I updated the commit message |
This is helpful when the Service Principal and the Resource group do not belong in the same Tenant.
Before this change trying to do so would give error showing that the ClientID was not found under TenantID of the Resource group.