Bump Azure SDK #447
Merged
Bump Azure SDK #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yiannistri
force-pushed
the
132-bump-azure-sdk-version
branch
5 times, most recently
from
1b8c2b2
to
847b6f4
Compare
yiannistri
force-pushed
the
132-bump-azure-sdk-version
branch
from
847b6f4
to
732e4f9
Compare
|
please rebase |
yiannistri
force-pushed
the
132-bump-azure-sdk-version
branch
from
732e4f9
to
cd8c198
Compare
yiannistri
force-pushed
the
132-bump-azure-sdk-version
branch
from
cd8c198
to
bfca293
Compare
mjura
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR bumps the Azure SDK dependencies and migrates the majority of the code away from the now deprecated Azure SDK. For more details about the SDK changes see here.
Which issue(s) this PR fixes
Issue #132
Special notes for your reviewer:
Notable changes:
github.com/golang/mock/mockgentogo.uber.org/mock/mockgenas the former is not being maintained anymore and the latter works well with generics, which the new version of the Azure SDK makes use of.EphemeralandManagedvalues toOsDiskTypeenum used in CRD as the new SDK uses them.ManagedClusterPropertiesstruct was embedded inManagedClusterwhereas in the new SDK, it is under aPropertiesfield.ManagedCluster.NetworkProfile.DockerBridgeCidrfield has been deprecated from the Azure API and therefore is no longer being set. However, we still need to deprecate it from the CRD API.Poller[T any]interface to allow for mocking long-running polls using the new SDK.Checklist: