Gatekeeper hull integration #2624
Conversation
doflamingo721
force-pushed
the
gatekeeper-hull-integration
branch
5 times, most recently
from
177f6fc
to
07c8944
Compare
doflamingo721
force-pushed
the
gatekeeper-hull-integration
branch
from
7e92782
to
9835f37
Compare
doflamingo721
changed the title
doflamingo721
force-pushed
the
gatekeeper-hull-integration
branch
2 times, most recently
from
01be249
to
c895934
Compare
| Name: "Set .postUpgrade.labelNamespace.image.repository and .postUpgrade.labelNamespace.image.tag", | ||
|
|
||
| TemplateOptions: chart.NewTemplateOptions(DefaultReleaseName, DefaultNamespace). | ||
| SetValue( |
There was a problem hiding this comment.
combine into one .Set() call
| TemplateOptions: chart.NewTemplateOptions(DefaultReleaseName, DefaultNamespace). | ||
| SetValue( | ||
| "postInstall.labelNamespace.image.repository", "test-gatekeeper-crd-repo", | ||
| ). |
|
|
||
| TemplateOptions: chart.NewTemplateOptions(DefaultReleaseName, DefaultNamespace). | ||
| Set( | ||
| "postInstall.labelNamespace.extraAnnotations", testPodAnnotation, |
|
I think a lot of test cases can be combined into one large one, might be a lot more readable. Also would have less cases to run. When the PR is done we can reevaluate |
doflamingo721
force-pushed
the
gatekeeper-hull-integration
branch
4 times, most recently
from
6581d9b
to
b16c55a
Compare
doflamingo721
force-pushed
the
gatekeeper-hull-integration
branch
from
b16c55a
to
ed5d3b8
Compare
| "validatingWebhookFailurePolicy", "Fail", | ||
| ), | ||
| }, | ||
| // { |
There was a problem hiding this comment.
Please remove commented out code from the PR
| ), | ||
| }, | ||
|
|
||
| // For .Values.postUpgrade |
There was a problem hiding this comment.
Remove the comment or fix formatting
|
|
||
| { | ||
| Name: "Set Values for postUpgrade", | ||
| TemplateOptions: chart.NewTemplateOptions(DefaultReleaseName, DefaultNamespace). |
There was a problem hiding this comment.
This case is repeated below
| ), | ||
| }, | ||
| // { | ||
| // Name: "Set postUpgrade.labelNamespace.image.pullSecrets with labelNamespace set to true", |
There was a problem hiding this comment.
Why are these commented out?
| // Name: "Set postUpgrade.labelNamespace.extraNamespaces", | ||
|
|
||
| // TemplateOptions: chart.NewTemplateOptions(DefaultReleaseName, DefaultNamespace). | ||
| // Set( |
There was a problem hiding this comment.
Are these cases supposed to be covered?
|
I have pointed out some issues with the PR, aside from the build failing. Please address the issues in ALL locations in the PR not just where I have commented. There is multiple instances of commented code left in, a repeated test case, and potentially not 100% test coverage. |
|
The hull testing coverage 100% coverage for the gatekeeper chart is not possible at the moment because of multiple issues in the upstream and rancher's gatekeeper template. Some of the issues are already logged (rancher/rancher#41688 and rancher/rancher#41689) but similar indentation and tolerations from values.yaml not getting applied to the templates issues still persist in other templates as well. Some fixes are already raised in the upstream chart for this (open-policy-agent/gatekeeper#2817 and open-policy-agent/gatekeeper#2862) but these fixes would be released with the new gatekeeper chart. As of now the chart coverage is at 97 percent. |
|
Hello @doflamingo721 and @eliyamlevy |
|
Unresponsive, closing. |
Linked issue: rancher/rancher#41026