Add Elemental Chart #2658
Add Elemental Chart #2658
Conversation
fgiudici
force-pushed
the
add_elemental
branch
2 times, most recently
from
53544b9
to
c942d34
Compare
| imagePullPolicy: IfNotPresent | ||
| + | ||
| +channel: | ||
| + repository: "registry.opensuse.org/isv/rancher/elemental/stable/teal53/15.4/rancher/elemental-teal-channel/5.3" |
There was a problem hiding this comment.
This should be rancher not registry.opensuse.org. You can add your docker image to https://github.com/rancher/image-mirror before submitting any new chart.
This goes for all other docker images. It should be rancher docker repo
There was a problem hiding this comment.
Hey @rohitsakala , thanks for the hint!
We build the images in OBS and now IBS: this means we end-up with our container images being in the registry.suse.com (just updated the link from opensuse to suse registry).
In particular, Elemental brings OS images as containers built on top of SLE OSes, so both the OS images and the channel (here the channel just carries the updated list of SLE based OS images) are build in IBS.
So all then is published on registry.suse.com.
IIUC, regular container images for the Rancher marketplace are uploaded from all the sources and mirrored on dockerhub. Then, for Rancher Prime, those images are mirrored on registry.suse.com from dockerhub.
Since the elemental container images are already built on IBS and automatically published on registry.suse.com, our plan would be to leave them there for everyone. How would that sound?
Updated with mirrored image links from rancher/image-mirror#428 (not there yet).
Added templating.
| + | ||
| +channel: | ||
| + repository: "registry.opensuse.org/isv/rancher/elemental/stable/teal53/15.4/rancher/elemental-teal-channel/5.3" | ||
| + tag: latest |
There was a problem hiding this comment.
Also, generally latest is not recommended. Can you please put the specific tag ?
There was a problem hiding this comment.
The channel here is just a container image carrying a list of URL with updated Elemental OSes, so we wanted it to keep updating... but your comment raised some discussion inside the team, and you are likely right: we need a specific tag here, but then we need to rethink how to provide OS updates 🤔
We'll need some time to address this
There was a problem hiding this comment.
You could update the image to the new tag and release a new Chart in rancher/charts by upgrading the version in package.yaml
There was a problem hiding this comment.
We will check the same image tag regularly and we may required to update it... we anyway need a fixed tag to match the specific Chart version (and so Elemental release). Updated to fixed tag 👍🏼
|
We need to wait for rancher/image-mirror#428 before merging this. |
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
Signed-off-by: Francesco Giudici <francesco.giudici@suse.com>
|
Target is now 2.8.0, moving to #3104 . |
Issue:
rancher/elemental-operator#492 - add Elemental helm charts in rancher/charts repo
Problem
Solution
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations