Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-v2.6] OOB Charts release for Monitoring Chart 0.3.0+up0.3.3 #2758

Merged
merged 8 commits into from
Jul 6, 2023

Conversation

diogoasouza
Copy link
Contributor

@diogoasouza diogoasouza commented Jul 5, 2023

Charts Checklist (built for v0.3.x charts-build-scripts)

Checkpoint 0: Validate release.yaml

Validation steps:

  • Each chart version in release.yaml DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.
  • Each chart version in release.yaml IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.

Checkpoint 1: Compare contents of assets/ to charts/

Validation steps:

  • Running make unzip to regenerate the charts/ from scratch, then git diff to check differences between assets/ and charts/ yields NO differences or innocuous differences.

IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!

Checkpoint 2: Compare assets against index.yaml

Validation steps:

  • The index.yaml file has an entry for each chart version.
  • The index.yaml entries for each chart matches the Chart.yaml for each chart.
  • Each chart has ALL required annotations
    • kube-version annotation
    • rancher-version annotation
    • permits-os annotation (indicates Windows and/or Linux)

Checkpoint 3: Logical Checks

Validation steps (requires manual inspection of differences between previous and latest chart version):

  • Ensure no RC images are included.
  • Ensure all mirrored images include the right prefix.
  • Ensure any new images have repository and tag on the same level to ensure the rancher-images.txt is generated correctly for it for airgap scenarios.

@rohitsakala rohitsakala marked this pull request as ready for review July 6, 2023 17:59
@rohitsakala rohitsakala merged commit f2208a3 into rancher:release-v2.6 Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants