Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rebase kube state metrics #2785

Closed
wants to merge 6 commits into from
Closed

Rebase kube state metrics #2785

wants to merge 6 commits into from

Conversation

joshmeranda
Copy link
Contributor

Issue:

rancher/rancher#42019

Problem

Solution

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@joshmeranda joshmeranda force-pushed the rebase-kube-state-metrics branch 2 times, most recently from bee772e to 024059d Compare September 5, 2023 13:54
@joshmeranda joshmeranda changed the base branch from dev-v2.7 to dev-v2.8 September 5, 2023 14:30
@joshmeranda joshmeranda force-pushed the rebase-kube-state-metrics branch 5 times, most recently from 16eb6ea to 5a5ec40 Compare September 7, 2023 16:15
@joshmeranda joshmeranda mentioned this pull request Sep 7, 2023
Merged
10 tasks
@geethub97 geethub97 self-requested a review September 12, 2023 19:47
@joshmeranda joshmeranda force-pushed the rebase-kube-state-metrics branch 2 times, most recently from 41f58b8 to ef7bfbf Compare September 18, 2023 19:03
@github-actions
Copy link

github-actions bot commented Oct 9, 2023

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@joshmeranda joshmeranda mentioned this pull request Oct 11, 2023
Merged
@joshmeranda
Copy link
Contributor Author

closing in favor of #3117

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geethub97 geethub97 Awaiting requested review from geethub97

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshmeranda @geethub97