Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Longhorn 1.5.1 chart with dev-2.7 #2797

Merged
merged 2 commits into from
Jul 28, 2023

Conversation

weizhe0422
Copy link
Contributor

@weizhe0422 weizhe0422 mentioned this pull request Jul 20, 2023
14 tasks
@weizhe0422 weizhe0422 force-pushed the dev-v2.7_LH_1.5.1 branch 2 times, most recently from 7218398 to bc1f6b9 Compare July 20, 2023 03:20
@weizhe0422
Copy link
Contributor Author

weizhe0422 commented Jul 20, 2023

Try to install Longhorn V1.5.1 via Rancher Apps but replace the image repository from rancher mirror: rancher/mirrored-longhornio- to longhornio/, the installation is successful.
image
image

Still need wait QA further verification and mirror images release: rancher/image-mirror#418

@khushboo-rancher @roger-ryao

@weizhe0422 weizhe0422 marked this pull request as ready for review July 20, 2023 03:29
@roger-ryao
Copy link

verify is passed this PR as follow step

The test steps

  1. Create pod_with_pvc. https://raw.githubusercontent.com/longhorn/longhorn/master/examples/pod_with_pvc.yaml
  2. Create orphaned data.
    SSH to one of the nodes and copy the contents of one replica directory,
    e.g., pvc-abc-…012, to a new directory named pvc-abc-…013. This will make pvc-abc-…013 an orphaned replica.
  3. Deploy a statefulSet and attach to the volume. https://raw.githubusercontent.com/longhorn/longhorn/master/examples/statefulset.yaml
  4. Validate that the volume is created and attached to the pod properly in the Longhorn GUI.
  5. Validate the pod is mounted properly.
  6. Scale down and up the statefulSet to check volume detach and attach is working fine.

@innobead
Copy link
Contributor

@roger-ryao have you tested the upgrade from the previous rancher chart? https://github.com/longhorn/longhorn/wiki/Release-Test-Plan---1.5.1 cc @khushboo-rancher

@roger-ryao
Copy link

upgrade from the previous rancher chart?

Hi @innobead :
I haven't tested the upgrade from the previous Rancher chart yet. Let me check it.

@innobead
Copy link
Contributor

Should do the same as you have done at #2780 (comment).

@roger-ryao
Copy link

Should do the same as you have done at #2780 (comment).

  • Fresh installation
  • Uninstallation
  • Upgrade from v1.4.2 - > v1.5.1
  • Upgrade from v1.4.3 - > v1.5.1

The test steps

  1. Create pod_with_pvc. https://raw.githubusercontent.com/longhorn/longhorn/master/examples/pod_with_pvc.yaml
  2. Create orphaned data.
    SSH to one of the nodes and copy the contents of one replica directory,
    e.g., pvc-abc-…012, to a new directory named pvc-abc-…013. This will make pvc-abc-…013 an orphaned replica.
  3. Deploy a statefulSet and attach to the volume. https://raw.githubusercontent.com/longhorn/longhorn/master/examples/statefulset.yaml
  4. Validate that the volume is created and attached to the pod properly in the Longhorn GUI.
  5. Validate the pod is mounted properly.
  6. Scale down and up the statefulSet to check volume detach and attach is working fine.

@weizhe0422 weizhe0422 force-pushed the dev-v2.7_LH_1.5.1 branch 2 times, most recently from 51b7f49 to 9441fb5 Compare July 27, 2023 02:46
@weizhe0422
Copy link
Contributor Author

@PhanLe1010 I've update the PR to include the new CRD: VolumeAttachment.

I also refer to Roger's test steps to do the upgrade testing from 1.4.2 to 1.5.1, and doing some tests:

  1. Install LH 1.4.2 in Rancher 2.7
  2. Deploy Pod and related PVC: https://raw.githubusercontent.com/longhorn/longhorn/master/examples/pod_with_pvc.yaml
  3. Writing some data into the mount point
  4. Upgrade to LH 1.5.1 in Rancher
  5. Deploy StatefulSet: https://raw.githubusercontent.com/longhorn/longhorn/master/examples/statefulset.yaml
  6. Make sure all of the workloads works well
    • volumes could attach to the node
    • data is intact after upgrading
    • new workload could be deployed normally
    • Scale down and up the statefulSet to check volume detach and attach is working fine

image

Copy link
Contributor

@PhanLe1010 PhanLe1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

rohitsakala
rohitsakala previously approved these changes Jul 27, 2023
index.yaml Outdated Show resolved Hide resolved
rohitsakala
rohitsakala previously approved these changes Jul 28, 2023
Signed-off-by: Ray Chang <ray.chang@suse.com>
Signed-off-by: Ray Chang <ray.chang@suse.com>
@rohitsakala rohitsakala merged commit fea1c09 into rancher:dev-v2.7 Jul 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants