[dev-v2.7] Add k8s 1.27 support to rancher-alerting chart #2840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,61 @@ | |||
| {{- if .Values.global.cattle.psp.enabled }} | |||
| apiVersion: policy/v1beta1 | |||
| kind: PodSecurityPolicy | |||
There was a problem hiding this comment.
Aren't PodSecurityPolicy removed since K8S 1.25 ?
(ref. https://kubernetes.io/blog/2021/04/06/podsecuritypolicy-deprecation-past-present-and-future/)
There was a problem hiding this comment.
Never mind. This chart already handles that when installed on K8S cluster that do not have that any longer.
#{{- if gt (len (lookup "rbac.authorization.k8s.io/v1" "ClusterRole" "" "")) 0 -}}
#{{- if .Values.global.cattle.psp.enabled }}
#{{- if not (.Capabilities.APIVersions.Has "policy/v1beta1/PodSecurityPolicy") }}
#{{- fail "The target cluster does not have the PodSecurityPolicy API resource. Please disable PSPs in this chart before proceeding." -}}
#{{- end }}
#{{- end }}
#{{- end }}
(ref. charts/rancher-alerting-drivers/102.1.1/templates/validate-psp-install.yaml)
|
Hello @doflamingo721 |
|
Unresponsive, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#41785
Testing
Testing instructions mentioned in the linked issue to be followed
Engineering Testing
Manual Testing
Installation of the chart on k8s 1.26 cluster since 1.27 is not available in rancher yet.