Update RBAC verbs to include create #2862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geethub97
requested review from
prachidamle,
pennyscissors,
aiyengar2 and
joshmeranda
joshmeranda
approved these changes
Aug 15, 2023
|
@aiyengar2 could you please review this RBAC change? |
aiyengar2
suggested changes
Aug 28, 2023
...g/rancher-monitoring/generated-changes/overlay/templates/rancher-monitoring/clusterrole.yaml
Outdated
Show resolved
Hide resolved
...g/rancher-monitoring/generated-changes/overlay/templates/rancher-monitoring/clusterrole.yaml
Outdated
Show resolved
Hide resolved
aiyengar2
approved these changes
Aug 31, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: rancher/rancher#40253
Problem
Error related to services/proxy when viewing metrics in Rancher UI
Solution
Add create verb to the services/proxy resource RBAC section
Testing
Repro steps in the GH ticket linked above are valid.