Update security-scan image for rancher-cis-benchmark #2871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxsokolovsky
approved these changes
Aug 15, 2023
KevinJoiner
suggested changes
Aug 15, 2023
Comment on lines
+27
to
+30
| rancher-aks-operator: | ||
| - 102.3.1+up1.1.3-rc1 | ||
| rancher-aks-operator-crd: | ||
| - 102.3.1+up1.1.3-rc1 |
There was a problem hiding this comment.
did you mean to move these?
There was a problem hiding this comment.
That's what make validate did. I think someone didn't validate before committing
KevinJoiner
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
rancher/rancher#42384
rancher/rancher#42385
rancher/rancher#42386
Problem
Several security checks had issues that needed to be fixed
Solution
See linked PRs in the above issues. This just updates the security-scan image used by rancher-cis-benchmark
Backporting considerations
Once rancher-cis-benchmark is un-RCed, we will need to update both 2.7 and 2.8