Istio 1.18 #2878
Merged
Istio 1.18 #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohitsakala
requested changes
Aug 18, 2023
rohitsakala
reviewed
Aug 25, 2023
| @@ -48,12 +49,13 @@ | |||
| - nodeSelector: | |||
| - {{- toYaml .Values.deployment.node_selector | nindent 8 }} | |||
| - {{- end }} | |||
| + tolerations: {{ include "linux-node-tolerations" . | nindent 8 }} | |||
| + {{- end }} | |||
There was a problem hiding this comment.
Please re check this indentation ?
diogoasouza
force-pushed
the
istio-1.18
branch
2 times, most recently
from
376168b
to
4545cb2
Compare
diogoasouza
force-pushed
the
istio-1.18
branch
from
4545cb2
to
9f0c07a
Compare
diogoasouza
force-pushed
the
istio-1.18
branch
from
9f0c07a
to
4694e57
Compare
diogoasouza
force-pushed
the
istio-1.18
branch
from
4694e57
to
662ff11
Compare
nicholasSUSE
approved these changes
Aug 25, 2023
rohitsakala
approved these changes
Aug 25, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes rancher/rancher#41782
fixes rancher/rancher#41833