Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding image check to pull request workflow and bumping scripts version #2882

Merged
merged 7 commits into from
Aug 28, 2023
Merged

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Aug 17, 2023

  • Adds a new step in the pull request workflow to check all the container images used in the project;
  • The step will run only if the pull request is opened against a release branch;
  • If the step fails, the workflow doesn't fail. The reason for this is that we have two tags from the fluent-bit repository that don't exist in Docker Hub. Until we figure that out, the new step would fail all the PRs if it was required to run successfully. After sorting the tags out we'll set the step success to be required;
  • Fixes rancher-external-ip-webhook chart description that is breaking the validation script.

@lucasmlp lucasmlp requested a review from a team August 17, 2023 21:43
@lucasmlp lucasmlp marked this pull request as draft August 17, 2023 22:04
@lucasmlp lucasmlp marked this pull request as ready for review August 24, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants