Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run check images in pull-request workflows and fails if it doesn't succeed #2883

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Run check images in pull-request workflows and fails if it doesn't succeed #2883

merged 2 commits into from
Aug 28, 2023

Conversation

lucasmlp
Copy link
Contributor

@lucasmlp lucasmlp commented Aug 18, 2023 •
edited
Loading

  • Enabling check images step in PRs opened against dev and release branches
  • Disabling continue-on-error for this step. This means that the whole workflow will fail if this step fails.

@lucasmlp lucasmlp changed the title Run check images in all PRs and fails if it doesn't succeed Run check images in pull-request workflows and fails if it doesn't succeed Aug 18, 2023
@rohitsakala rohitsakala merged commit 7dcb30a into rancher:dev-v2.7 Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitsakala rohitsakala rohitsakala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasmlp @rohitsakala