-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Endpoint auth #2962
Endpoint auth #2962
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add the version and package to release.yaml as well ?
charts/rancher-monitoring/103.0.0+up40.1.2/charts/hardenedKubelet/Chart.yaml
Outdated
Show resolved
Hide resolved
charts/rancher-monitoring/103.0.0+up40.1.2/charts/hardenedNodeExporter/Chart.yaml
Outdated
Show resolved
Hide resolved
charts/rancher-monitoring/103.0.0+up40.1.2/charts/k3sServer/Chart.yaml
Outdated
Show resolved
Hide resolved
charts/rancher-monitoring/103.0.0+up40.1.2/charts/kubeAdmControllerManager/Chart.yaml
Outdated
Show resolved
Hide resolved
e988c2b
to
84c16e7
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
84c16e7
to
fe06532
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
fe06532
to
efc23b1
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
efc23b1
to
b0d2509
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
b0d2509
to
6d02c37
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from mapps perspective.
@joshmeranda Also, a general question, can customers install |
@rohitsakala They can, it can work on its own but it was designed to work with rancher-monitoring not the vanilla kube-prometheus-stack. So unless the user wants to go through the process of configuring their prometheus deployments to use it, it wouldn't do them much good. Even then its probably still not worth the effort. If they want to use the pushprox, they might as well just use rancher-monitoring. |
replaces #2851
Issue:
rancher/rancher#43414
rancher/rancher#43387
Problem
In its current configuration, without using the proxies, which do not work with the upstream chart, users cannot authenticate to kubernetes api endpoints that require authentication to access them. Additionally, since the same endpoints do not expose certificates to any ip but 127.0.0.1, I've added the capability to honor the insecureSkipVerify flag if it is set. While I was there, I also fixed a bug in metricRelabelings where it would generate an empty list if not configured, it would generate an invalid list if not configured.
text copied for original PR
Solution
This adds the ability to use authentication on the clients to the kubernetes components. Added the ability to correctly set the http(s) scheme if not using the proxy feature. Fixed a bug so service monitors will honor the insecureSkipVerify flag if set by the client. Fixed a bug in metricRelabelings where it would generate an empty list if not configured. Added imagepullsecrets as a global field to be used whenever an image is pulled.
text copied for original PR
Testing
Engineering Testing
Manual Testing
Automated Testing
QA Testing Considerations
Regressions Considerations
Backporting considerations
2.7x and 2.6x
rancher/rancher#42716
rancher/rancher#42720