Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.8] rancher-logging rke2 patch kubelet logs volume mount to follow rotates #3452

Conversation

alexandreLamarre
Copy link
Contributor

@alexandreLamarre alexandreLamarre commented Feb 9, 2024

Issue:

SURE-7276

Problem

fluentbit cannot follow log rotates for the hostpath /var/lib/rancher/rke2/agent/logs/kubelet.log on rke2

Solution

Mount the hostpath directory /var/lib/rancher/rke2/agent/logs to prevent the volume bind from locking the file kubelet.log so that fluentbit can follow file changes

Testing

Engineering Testing

Manual Testing

logging on rke2 collects rke kubelet logs

Automated Testing

N/A

QA Testing Considerations

rancher-logging on rke2

Regressions Considerations

N/A

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Copy link

github-actions bot commented Feb 9, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@alexandreLamarre alexandreLamarre marked this pull request as ready for review February 9, 2024 17:12
@alexandreLamarre alexandreLamarre changed the title [dev-v2.8] [WIP] rancher-logging rke2 patch kubelet logs volume mount to follow rotates [dev-v2.8] rancher-logging rke2 patch kubelet logs volume mount to follow rotates Feb 9, 2024
@alexandreLamarre alexandreLamarre merged commit 868f07f into rancher:dev-v2.8 Feb 12, 2024
6 checks passed
@pankajsqe
Copy link

On fresh installation of logging chart in RKE2 v1.26.13+rke2r1 was successful, There were logs in Pod: rancher-logging-rke2-journald-aggregator-jzxj9

Later on upgrade scenario from RKE2 v1.24.14+rke2r1 to RKE2 v1.26.13+rke2r1 I checked Pod: rancher-logging-rke2-journald-aggregator-jzxj9 This time there are no logs in it and there are mountfailures too

Details
rancher 2.8.3-rc3
dev-2.8
Inital cluster : v1.24.14+rke2r1
Upgrade Cluster : v1.26.13+rke2r1

Screenshot 2024-03-14 at 9 11 21 PM Screenshot 2024-03-14 at 9 12 23 PM

@MKlimuszka MKlimuszka added this to the v2.8-Next1 milestone Mar 19, 2024
lucasmlp pushed a commit that referenced this pull request Mar 26, 2024
…llow rotates (#3452)

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
lucasmlp pushed a commit that referenced this pull request Mar 27, 2024
…llow rotates (#3452)

Signed-off-by: Alexandre Lamarre <alexandre.lamarre@suse.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants