Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dev-v2.9] Disabled hull tests #3516

Closed
wants to merge 1 commit into from

Conversation

vardhaman22
Copy link
Contributor

@vardhaman22 vardhaman22 commented Feb 26, 2024

Issue:

due to helm bump to v3.14.1 there is an issue in rancher/hull repository.

Problem

there is an issue with template parsing in rancher/hull because of bumping helm to v3.14.1

Solution

disabling psp tests for now so that we can bump helm in rancher/charts and then we can re-enable them when hull is fixed.

Testing

Engineering Testing

Manual Testing

Automated Testing

QA Testing Considerations

Regressions Considerations

Backporting considerations

@vardhaman22 vardhaman22 marked this pull request as ready for review February 26, 2024 08:14
@recena recena changed the title [v2.9] disabled hull tests [dev-v2.9] disabled hull tests Feb 26, 2024
@lucasmlp lucasmlp changed the title [dev-v2.9] disabled hull tests [dev-v2.9] Disabled hull tests Mar 1, 2024
Copy link
Contributor

@lucasmlp lucasmlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to change this for now. The go.mod file was not modified so it's using a set of helm and hull dependencies that works.
All workflows are running the hull tests normally.
I think this change would be needed if we upgraded helm and hull dependencies.

@adamkpickering
Copy link
Contributor

@lucasmlp agreed. Can we close this then?

@lucasmlp
Copy link
Contributor

lucasmlp commented Mar 1, 2024

@adamkpickering I was looking into the issues related to this one. Seems like Dependabot tried to update our helm library to v3.14.1, but the hull tests broke because the hull version capable of working with helm v3.14.1 is broken. I believe that there will be a version of hull that works with helm v.3.14 once rancher/hull#43 is merged as described in the hull PR by @vardhaman22.
We could wait for a week to see if rancher/hull#43 is merged and if not, close this and the respective rancher/charts PRs

@adamkpickering
Copy link
Contributor

IMO this PR is unnecessary. Unless I'm missing something, we don't need to disable the hull tests until helm is bumped, because nothing is broken.

Closing for now. If I'm missing something @vardhaman22 @lucasmlp please reopen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants