-
Notifications
You must be signed in to change notification settings - Fork 718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-v2.7] 3rd Batch Charts release for fleet, rancher-webhook, sriov, rancher-vsphere-csi, rancher-vsphere-cpi and rancher-backup #3523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholasSUSE
force-pushed
the
3rd-batch-release-2.7.11
branch
from
February 26, 2024 23:50
a0098f0
to
03dd5d4
Compare
This might need to be reverted. Attention @manno
Co-authored-by: fleet-bot <fleet@suse.de>
Co-authored-by: fleet-bot <fleet@suse.de>
Signed-off-by: Michael Fritch <mfritch@suse.com>
nicholasSUSE
force-pushed
the
3rd-batch-release-2.7.11
branch
from
February 26, 2024 23:56
03dd5d4
to
cd7e16f
Compare
lucasmlp
changed the title
3rd batch release 2.7.11
[release-v2.7] 3rd Batch Charts release for fleet, rancher-webhook, sriov, rancher-vsphere-csi, rancher-vsphere-cpi and rancher-backup
Feb 27, 2024
nicholasSUSE
force-pushed
the
3rd-batch-release-2.7.11
branch
from
February 27, 2024 00:27
4fc8a85
to
cd7e16f
Compare
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
lucasmlp
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Validation steps
Ex:- longhorn-controller: repository: rancher/hardened-sriov-cni tag: v2.6.3-build20230913
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
fleet && crd && agent:
rancher-webhook:
system-upgrade-controller:
rancher-vsphere-csi && rancher-vsphere-cpi:
rancher-cis-benchmark && crd:
sriov && crd:
Charts Checklist (built for v0.5.2 charts-build-scripts)
Checkpoint 0: Validate
release.yaml
Validation steps:
release.yaml
DOES NOT modify an already released chart. If so, stop and modify the versions so that it releases a net-new chart.release.yaml
IS exactly 1 more patch version than the last released chart version. If not, stop and modify the versions so that it releases a net-new chart.Checkpoint 1: Compare contents of assets/ to charts/
Validation steps:
make unzip
to regenerate thecharts/
from scratch, thengit diff
to check differences betweenassets/
andcharts/
yields NO differences or innocuous differences.IMPORTANT: Do not undo these changes for future steps since we want to keep the charts/ that match the current contents of assets!
Checkpoint 2: Compare assets against index.yaml
Validation steps: